Skip to content

feat: add wrap IEvaluator for scope.#183

Merged
hsluoyz merged 2 commits into
apache:masterfrom
sheny1xuan:exprtk_evalator
Feb 17, 2022
Merged

feat: add wrap IEvaluator for scope.#183
hsluoyz merged 2 commits into
apache:masterfrom
sheny1xuan:exprtk_evalator

Conversation

@sheny1xuan
Copy link
Copy Markdown
Contributor

Signed-off-by: stonex 1479765922@qq.com

Fixes #

Description

  • Delete enforce with scope and wrap scope with IEvaluator. So, we can change different evaluator by inheriting IEvaluator.
  • Add exprtk header file.

Screenshots/Testimonials

Signed-off-by: stonex <1479765922@qq.com>
@casbin-bot
Copy link
Copy Markdown

@EmperorYP7 @divy9881 @noob20000405 please review

@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Feb 13, 2022

@EmperorYP7 plz review

Copy link
Copy Markdown
Contributor

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on my machine. Works without any errors.

LGTM!

Comment thread casbin/model/evaluator.cpp Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 17, 2022

CLA assistant check
All committers have signed the CLA.

@hsluoyz hsluoyz merged commit dc3224c into apache:master Feb 17, 2022
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.46.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants